Skip to content

Revert "[pulsar-client-java] retry when getPartitionedTopicMetadata failed - #5733

Merged
wolfstudy merged 1 commit into
branch-2.4from
revert-5603-branch-2.4
Nov 25, 2019
Merged

Revert "[pulsar-client-java] retry when getPartitionedTopicMetadata failed#5733
wolfstudy merged 1 commit into
branch-2.4from
revert-5603-branch-2.4

Conversation

@wolfstudy

@wolfstudy wolfstudy commented Nov 25, 2019

Copy link
Copy Markdown
Member

Motivation

Revert the #5603 from branch-2.4.

This pr does not seem to be merged to branch-2.4, because getDefaultBackoffIntervalNanos, useUserConfiguredIntervals is not defined in branch-2.4.

@wolfstudy
wolfstudy requested a review from sijie November 25, 2019 02:46
@wolfstudy wolfstudy self-assigned this Nov 25, 2019
@wolfstudy
wolfstudy requested a review from jiazhai November 25, 2019 03:48
@wolfstudy wolfstudy changed the title Revert "[Issue 5597][pulsar-client-java] retry when getPartitionedTop… Revert "[pulsar-client-java] retry when getPartitionedTopicMetadata failed Nov 25, 2019
@sijie

sijie commented Nov 25, 2019

Copy link
Copy Markdown
Member

@wolfstudy thank you for point this out.

Can you also send out a pull request to apply #5603 to master?

@wolfstudy

Copy link
Copy Markdown
Member Author

Can you also send out a pull request to apply #5603 to master?

Sure

@sijie

sijie commented Nov 25, 2019

Copy link
Copy Markdown
Member

run cpp tests
run integration tests

@wolfstudy

Copy link
Copy Markdown
Member Author

run cpp tests

1 similar comment
@wolfstudy

Copy link
Copy Markdown
Member Author

run cpp tests

@sijie

sijie commented Nov 25, 2019

Copy link
Copy Markdown
Member

I don't think we are able to pass the c++ test because of the way how the tests setup. The tests don't run well on branches. If this is a revert change, we can just merge it. We should figure out a robust plan to test branches.

@wolfstudy

Copy link
Copy Markdown
Member Author

I don't think we are able to pass the c++ test because of the way how the tests setup. The tests don't run well on branches. If this is a revert change, we can just merge it. We should figure out a robust plan to test branches.

Thanks sijie, i will merge this pull request and open issue track the test in branch.

@wolfstudy
wolfstudy merged commit 811dd45 into branch-2.4 Nov 25, 2019
@sijie
sijie deleted the revert-5603-branch-2.4 branch December 9, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants