Skip to content

[broker] Remove duplicated lombok annotations in tests - #6130

Merged
merlimat merged 2 commits into
apache:masterfrom
vzhikserg:remove-duplicated-lombok-annotations-in-broker
Jan 23, 2020
Merged

[broker] Remove duplicated lombok annotations in tests#6130
merlimat merged 2 commits into
apache:masterfrom
vzhikserg:remove-duplicated-lombok-annotations-in-broker

Conversation

@vzhikserg

@vzhikserg vzhikserg commented Jan 23, 2020

Copy link
Copy Markdown
Contributor

Motivation

Some of the classes in the pulsar-broker module had a mixture of the following lombok annotations:

@Data
@Setter	
@Getter	
@EqualsAndHashCode	
@ToString

The @Data annotation includes all other annotations:

All together now: A shortcut for @tostring, @EqualsAndHashCode, @Getter on all fields, @Setter on all non-final fields, and @requiredargsconstructor!

Modifications

Removed @Setter, @Getter, @EqualsAndHashCode, and '@tostring' if the @Data annotation was also present

@sijie sijie added area/test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use labels Jan 23, 2020
@merlimat merlimat added this to the 2.6.0 milestone Jan 23, 2020
@merlimat
merlimat merged commit d0920fc into apache:master Jan 23, 2020
@vzhikserg
vzhikserg deleted the remove-duplicated-lombok-annotations-in-broker branch January 23, 2020 17:12
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants