Add configurable DNS client for ConnectionPool - #6382
Closed
diegosalvi wants to merge 1 commit into
Closed
Conversation
sijie
requested changes
Feb 22, 2020
sijie
left a comment
Member
There was a problem hiding this comment.
@diegosalvi the change looks good. although there is one small problem we need to think about - the pulsar-client is shipped by shading its dependencies. Hence DnsNameResolverBuilder will be shaded as well. so the end-users will be using the shaded class for configuring the DnsResolver.
So I would suggest defining a DnsResolverConfig in pulsar-client-api, and allow use configuring a DnsResolver by passing in a DnsResolverConfig. So we don't directly expose netty classes in Pulsar API.
Contributor
Author
|
I'll add a configuration bean then :) |
Contributor
|
@diegosalvi Any updates on this PR? Move this PR to 2.7.0 and If there is any update, move it back. |
|
Any updates on the state of this? |
Member
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6346
Motivation
Currently DNS client for PulsarClient cannot be configured and we are struck with default one. Specifically I needed to be able to configure the dns server list
Modifications
ClientBuilder.dnsConnectionPoolVerifying this change
This change is essentially a trivial rework, it just expose the ability to provider a custom DnsNameResolverBuilder and use it if provided.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation