Issue-6403: Consumer received duplicated deplayed messages upon restart - #6404
Merged
codelipenghui merged 1 commit intoFeb 26, 2020
Merged
Conversation
…arts and pull duplicate messages.
Member
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Feb 25, 2020
sijie
approved these changes
Feb 26, 2020
codelipenghui
approved these changes
Feb 26, 2020
Member
|
cherry-picked into branch-2.5 |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix when send a delayed message ,there is a case when a consumer restarts and pull duplicate messages. #6403
read entry
Order of reading messages
1、getMessagesToReplayNow
2、asyncReadEntriesOrWait
send consumer
normal situation
1、ReadType.Normal
Because the delay time has not arrived
but filterEntriesForConsumer method will fileter
2、ReadType.Replay
delay time has arrived ,and send consumer
abnormal situation
when the delay time has not arrived, stop conumser,
then the delay time has arrived, start conumser.
1、ReadType.Replay
delay time has arrived ,and send consumer
2、ReadType.Normal
delay time has arrived ,and send consumer
Changes
update readPosition to next