change nondurable cursor to active - #6769
Merged
codelipenghui merged 1 commit intoApr 22, 2020
Merged
Conversation
merlimat
requested changes
Apr 19, 2020
merlimat
left a comment
merlimat
left a comment
Contributor
There was a problem hiding this comment.
This is not the right fix since it would cache even if the cursor is reading older data
Contributor
Author
@merlimat I think the cursor will be set inactive by the interval backlog check. |
Contributor
@zhaorongsheng You're probably right. Let me review this more in depth tomorrow since it was a long time since I touched it. |
Contributor
Author
OK. Thanks~ |
sijie
added
area/broker
release/2.5.2
type/enhancement
sijie
approved these changes
Apr 21, 2020
Member
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Apr 22, 2020
codelipenghui
approved these changes
Apr 22, 2020
addisonj
pushed a commit
to instructure/pulsar
that referenced
this pull request
May 7, 2020
### Motivation When use non-durable subscription the cursor is not active which lead to the written entries are not put into cache. This situation would degrade reading performance. ### Modifications Change the `NonDurableCursorImpl` to active and remove the three override methods: `setActive()/isActive()/setInactive()` ### Verifying this change This change added tests and can be verified as follows: *ManagedCursorTest.testNonDurableCursorActive()* - add test to check `NonDurableCursorImpl` activity
jiazhai
pushed a commit
that referenced
this pull request
May 8, 2020
### Motivation When use non-durable subscription the cursor is not active which lead to the written entries are not put into cache. This situation would degrade reading performance. ### Modifications Change the `NonDurableCursorImpl` to active and remove the three override methods: `setActive()/isActive()/setInactive()` ### Verifying this change This change added tests and can be verified as follows: *ManagedCursorTest.testNonDurableCursorActive()* - add test to check `NonDurableCursorImpl` activity (cherry picked from commit 16ab351)
jerrypeng
pushed a commit
to jerrypeng/incubator-pulsar
that referenced
this pull request
May 15, 2020
### Motivation When use non-durable subscription the cursor is not active which lead to the written entries are not put into cache. This situation would degrade reading performance. ### Modifications Change the `NonDurableCursorImpl` to active and remove the three override methods: `setActive()/isActive()/setInactive()` ### Verifying this change This change added tests and can be verified as follows: *ManagedCursorTest.testNonDurableCursorActive()* - add test to check `NonDurableCursorImpl` activity
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation When use non-durable subscription the cursor is not active which lead to the written entries are not put into cache. This situation would degrade reading performance. ### Modifications Change the `NonDurableCursorImpl` to active and remove the three override methods: `setActive()/isActive()/setInactive()` ### Verifying this change This change added tests and can be verified as follows: *ManagedCursorTest.testNonDurableCursorActive()* - add test to check `NonDurableCursorImpl` activity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When use non-durable subscription the cursor is not active which lead to the written entries are not put into cache. This situation would degrade reading performance.
Modifications
Change the
NonDurableCursorImplto active and remove the three override methods:setActive()/isActive()/setInactive()Verifying this change
This change added tests and can be verified as follows:
ManagedCursorTest.testNonDurableCursorActive()
NonDurableCursorImplactivity