Skip to content

Fix compilation issue due to conflicting changes - #7147

Closed
srkukarni wants to merge 2 commits into
apache:masterfrom
srkukarni:compile_fix
Closed

Fix compilation issue due to conflicting changes#7147
srkukarni wants to merge 2 commits into
apache:masterfrom
srkukarni:compile_fix

Conversation

@srkukarni

Copy link
Copy Markdown
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

#7103 and #7090 had conflicts. This pr fixes compilation error.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@srkukarni srkukarni added this to the 2.6.0 milestone Jun 2, 2020
@srkukarni
srkukarni requested review from jerrypeng and merlimat June 2, 2020 23:20
@srkukarni srkukarni self-assigned this Jun 2, 2020
@srkukarni

Copy link
Copy Markdown
Contributor Author

Failing to build images because of space.

@codelipenghui

Copy link
Copy Markdown
Contributor

@srkukarni I'm also trying to fix the disk space problem at #7141.

@codelipenghui

Copy link
Copy Markdown
Contributor

Close this PR since the master branch is fixed by #7141. Please reopen it if there are still problems there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants