Add more detail information of retry errors - #7341
Merged
Merged
Conversation
--- *Motivation* Currently, when you connecting to a wrong address, the error log does not show the detail information to let you know why it failed. Add the failed reason to know more about the error. Before adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted. ``` After adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081 ```
merlimat
approved these changes
Jun 23, 2020
jiazhai
approved these changes
Jun 24, 2020
codelipenghui
approved these changes
Jun 27, 2020
codelipenghui
left a comment
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
Would you please take a look at the check style issue?
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
3 similar comments
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
5 similar comments
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
codelipenghui
pushed a commit
to streamnative/pulsar-archived
that referenced
this pull request
Jul 14, 2020
--- *Motivation* Currently, when you connecting to a wrong address, the error log does not show the detail information to let you know why it failed. Add the failed reason to know more about the error. Before adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted. ``` After adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081 ``` (cherry picked from commit f4547ec)
wolfstudy
pushed a commit
that referenced
this pull request
Jul 29, 2020
--- *Motivation* Currently, when you connecting to a wrong address, the error log does not show the detail information to let you know why it failed. Add the failed reason to know more about the error. Before adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted. ``` After adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081 ``` (cherry picked from commit f4547ec)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
--- *Motivation* Currently, when you connecting to a wrong address, the error log does not show the detail information to let you know why it failed. Add the failed reason to know more about the error. Before adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted. ``` After adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when you connecting to a wrong address, the error
log does not show the detail information to let you know why
it failed. Add the failed reason to know more about the error.
Before adding the error log:
After adding the error log: