Skip to content

fix update partitions error for non-persistent topic #7459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merlimat merged 1 commit into from
Jul 6, 2020
Merged

fix update partitions error for non-persistent topic #7459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,10 +357,9 @@ protected void validatePartitionedTopicName(String tenant, String namespace, Str
}

protected void validatePartitionedTopicMetadata(String tenant, String namespace, String encodedTopic) {
String completeTopicName = tenant + "/" + namespace + "/" + Codec.decode(encodedTopic);
try {
PartitionedTopicMetadata partitionedTopicMetadata =
pulsar().getBrokerService().fetchPartitionedTopicMetadataAsync(TopicName.get(completeTopicName)).get();
pulsar().getBrokerService().fetchPartitionedTopicMetadataAsync(topicName).get();
if (partitionedTopicMetadata.partitions < 1) {
throw new RestException(Status.CONFLICT, "Topic is not partitioned topic");
}
Expand Down
2 changes: 2 additions & 0 deletions pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminResourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,10 @@ public void testValidatePartitionedTopicMetadata() throws Exception {
AdminResource resource = mockResource();
resource.setPulsar(pulsar);
// validate should pass when topic is partitioned topic
resource.validatePartitionedTopicName(tenant, namespace, Codec.encode(partitionedTopic));
resource.validatePartitionedTopicMetadata(tenant, namespace, Codec.encode(partitionedTopic));
// validate should failed when topic is non-partitioned topic
resource.validatePartitionedTopicName(tenant, namespace, Codec.encode(nonPartitionedTopic));
try {
resource.validatePartitionedTopicMetadata(tenant, namespace, Codec.encode(nonPartitionedTopic));
fail("Should fail validation on non-partitioned topic");
Expand Down