Cpp oauth2 auth client - #7467
Merged
Merged
Conversation
Member
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jul 8, 2020
sijie
reviewed
Jul 8, 2020
sijie
left a comment
sijie
left a comment
Member
There was a problem hiding this comment.
A couple of questions:
-
It seems that in Java plugin we are using encoded auth param string but in c++ client, we don't use encoded auth param. Is there any reason?
-
I think it is worth supporting reading client credentials from a JSON file. So applications can configure to read the credentials from a credentials file. We should support a similar feature in Java client similar as what we did for Token provider.
-
We need to add documentation in c++ client.
Member
Author
Thanks @sijie for the reminder, opened new issue to track the reminding work. |
wolfstudy
pushed a commit
that referenced
this pull request
Jul 29, 2020
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation apache#7420 provides an Oauth2 auth client for java. This PR tries to support it in cpp client ### Modifications - add implementation - add related tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#7420 provides an Oauth2 auth client for java. This PR tries to support it in cpp client
Modifications