fix bug: https://github.com/apache/pulsar/issues/7706 - #7774
Closed
xuesongxs wants to merge 1 commit into
Closed
Conversation
Jennifer88huang-zz
requested review from
rdhabalia and
sijie
and removed request for
sijie
August 7, 2020 03:48
Contributor
|
Changes in #7690 seem to be reverted. Is this intentional? |
Contributor
Author
|
Yes, I submitted the code one day later than the latest code in the master branch. I passed the test on the old code, but did not merge and retest the latest code of the master branch.
daxia_xue@126.com
From: Masahiro Sakamoto
Date: 2020-08-12 10:57
To: apache/pulsar
CC: xuesong172500; Assign
Subject: Re: [apache/pulsar] fix bug: #7706 (#7774)
Changes in #7690 seem to be reverted. Is this intentional?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Contributor
Contributor
Author
|
Yes, I will fork the master branch again and submit a new pull request.
daxia_xue@126.com
From: Masahiro Sakamoto
Date: 2020-08-12 13:12
To: apache/pulsar
CC: xuesong172500; Assign
Subject: Re: [apache/pulsar] fix bug: #7706 (#7774)
If we revert #7690 changes, the deadlock issue will reappear, so we should not it. Can the issue of #7706 be reproduced on the master branch? If so, could you fix the code in the master branch?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Contributor
Author
Contributor
|
If #7690 has already solved the issue, I will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7706
Motivation
Pulsar-Proxy/Pulsar-Discovery-Service No active broker is available
Modifications
Change zookeeper getValue interface