Skip to content

Allow to build Pulsar on JDK14+ - #7951

Closed
eolivelli wants to merge 5 commits into
apache:masterfrom
eolivelli:fix/build-jdk14
Closed

Allow to build Pulsar on JDK14+#7951
eolivelli wants to merge 5 commits into
apache:masterfrom
eolivelli:fix/build-jdk14

Conversation

@eolivelli

@eolivelli eolivelli commented Sep 1, 2020

Copy link
Copy Markdown
Contributor

Motivation

Currently Pulsar does not build on JDK14

Modifications

  • update Maven Assembly plugin
  • use explicit import for Record class (prevent clash with java.lang.Record)
  • move maven-git-commit-id plugin execution only inside Pulsar Common (in order to speed up the build)

Verifying this change

This change is already covered by existing tests

@eolivelli

Copy link
Copy Markdown
Contributor Author

This change is not intended to make tests pass, only to allow a full clean build.
Fixing tests will be a follow up work

@eolivelli

Copy link
Copy Markdown
Contributor Author

rerun failure tests

@rdhabalia

Copy link
Copy Markdown
Contributor

/pulsarbot run-failure-checks

@eolivelli

Copy link
Copy Markdown
Contributor Author

thank you @rdhabalia

@codelipenghui

Copy link
Copy Markdown
Contributor

/pulsarbot run-failure-checks

@jiazhai

jiazhai commented Sep 3, 2020

Copy link
Copy Markdown
Member

/pulsarbot run-failure-checks

@jiazhai

jiazhai commented Sep 8, 2020

Copy link
Copy Markdown
Member

/pulsarbot run-failure-checks

2 similar comments
@mkozioro

mkozioro commented Sep 8, 2020

Copy link
Copy Markdown
Contributor

/pulsarbot run-failure-checks

@jiazhai

jiazhai commented Sep 9, 2020

Copy link
Copy Markdown
Member

/pulsarbot run-failure-checks

@eolivelli

Copy link
Copy Markdown
Contributor Author

Is it normal this series of failures ?

@eolivelli

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

@eolivelli

Copy link
Copy Markdown
Contributor Author

The upgrade of plugins determined changes in the final output of the binaries.
I see license errors and probably also integration tests are related

- update Apache Maven Assembly Plugin
- use explicit import for Record class (prevent clash with java.lang.Record)
@eolivelli eolivelli changed the title Allow to build Pulsar on JDK14 Allow to build Pulsar on JDK14+ Oct 22, 2020
@eolivelli

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

@eolivelli

Copy link
Copy Markdown
Contributor Author

I cannot reproduce CI errors locally, opening a new PR #8360

@eolivelli eolivelli closed this Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants