[Client] java client support UnAvroBased Schema#8246
Merged
Conversation
Contributor
Author
|
/pulsarbot run-failure-checks |
hnail
changed the title
hnail
changed the title
hnail
changed the title
Contributor
Author
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Oct 21, 2020
Member
|
@hnail The change looks great to me! It is a great refactor to support both AvroBased and UnAvroBased schemas. Thank you for your contributions! |
Member
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Oct 26, 2020
Contributor
|
/pulsarbot run-failure-checks |
Contributor
Author
Thank for your review ，I have commit a UnAvroBasedSchema |
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
### Motivation JAVA client support UnAvroBasedSchema ### Modifications - `schema` division to **AvroBasedSchema** and **UnAvroBasedSchema** : AvroBased Schema | UnAvroBased Schema ------------ | ------------- StructSchema | AbstractStructSchema GenericSchemaImpl | AbstractGenericSchema - `GenericSchema` add `of()` method , `GenericSchemaImpl` and `StructSchema` continue to have for backward compatibility and only support AvroBased Schema 。
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
### Motivation JAVA client support UnAvroBasedSchema ### Modifications - `schema` division to **AvroBasedSchema** and **UnAvroBasedSchema** : AvroBased Schema | UnAvroBased Schema ------------ | ------------- StructSchema | AbstractStructSchema GenericSchemaImpl | AbstractGenericSchema - `GenericSchema` add `of()` method , `GenericSchemaImpl` and `StructSchema` continue to have for backward compatibility and only support AvroBased Schema 。
Member
|
Confirmed w/ @congbobo184, no need to update doc for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
JAVA client support UnAvroBasedSchema
Modifications
schemadivision to AvroBasedSchema and UnAvroBasedSchema :GenericSchemaaddof()method ,GenericSchemaImplandStructSchemacontinue to have for backward compatibility and only support AvroBased Schema 。Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation