Add nettyMaxFrameSizeBytes setting to standalone.conf - #8385
Merged
merlimat merged 1 commit intoOct 27, 2020
Merged
Conversation
merlimat
approved these changes
Oct 27, 2020
rdhabalia
approved these changes
Oct 27, 2020
Contributor
|
/pulsarbot run-failure-checks |
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Nov 13, 2020
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nettyMaxFrameSizeBytessetting added to bookkeeper.conf in #7116 should also be added to standalone.conf. In addition, the comment was incorrect, so I fixed it. The default value should be 5MB instead of 1GB.https://github.com/apache/bookkeeper/blob/4c6cf097d9b823c8e839e176a06266a58bcb7bf5/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java#L145-L146