Skip to content

[PIP-71][SQL]Pulsar SQL migrate SchemaHandle to presto decoder #8422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiazhai merged 26 commits into from
Feb 1, 2021
Merged

[PIP-71][SQL]Pulsar SQL migrate SchemaHandle to presto decoder #8422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
86fb725
[SQL] migrate SchemaHandle to decoder
Nov 2, 2020
703c15c
Merge branch 'master' of https://github.com/apache/pulsar into sql_mi…
Nov 9, 2020
f94e770
commit unit-tests
Nov 9, 2020
4d2755b
fix Pair bug
Nov 9, 2020
98d5ea3
codestyle fix
Nov 10, 2020
9dd57e0
codestyle fix v2
Nov 10, 2020
66be5b2
codestyle fix v3
Nov 10, 2020
e61a37d
codestyle fix v4
Nov 10, 2020
8f93600
codestyle fix v5
Nov 10, 2020
203dc36
codeStyle fix v6
Nov 11, 2020
aa636b9
codeStyle fix v7
Nov 11, 2020
6cfe40e
add License
Nov 11, 2020
592130b
add snappy license
Nov 12, 2020
7c5f93c
codeStyle fix
Nov 16, 2020
f0a0c61
Update pulsar-sql/presto-pulsar/src/test/java/org/apache/pulsar/sql/p…
hnail Dec 1, 2020
bf98970
Update pulsar-sql/presto-pulsar/src/test/java/org/apache/pulsar/sql/p…
hnail Dec 1, 2020
dbcf5cd
Update pulsar-sql/presto-pulsar/src/test/java/org/apache/pulsar/sql/p…
hnail Dec 1, 2020
2563199
Merge branch 'master' of https://github.com/apache/pulsar into sql_mi…
Dec 17, 2020
8cc673b
Merge branch 'master' of https://github.com/apache/pulsar into sql_mi…
Dec 20, 2020
11c0cef
add keyValue\Primitive schema test && add schema cyclic definition de…
Dec 23, 2020
7f20d17
Merge branch 'master' of https://github.com/apache/pulsar into sql_mi…
Dec 23, 2020
6091b22
Merge branch 'master' into sql_migrate_decoder
hnail Jan 18, 2021
b91a0e4
Merge branch 'sql_migrate_decoder' of github.com:hnail/pulsar into sq…
Jan 18, 2021
c54c1d0
merge master
Jan 19, 2021
16626f2
Merge branch 'master' of https://github.com/apache/pulsar into sql_mi…
Jan 29, 2021
73dadc6
merge master
Jan 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pulsar-sql/presto-distribution/LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,7 @@ The Apache Software License, Version 2.0
- presto-parser-332.jar
- presto-plugin-toolkit-332.jar
- presto-spi-332.jar
- presto-record-decoder-332.jar
* RocksDB JNI
- rocksdbjni-6.10.2.jar
* SnakeYAML
Expand Down Expand Up @@ -433,6 +434,8 @@ The Apache Software License, Version 2.0
- commons-logging-1.2.jar
* GSON
- gson-2.8.6.jar
* Snappy
- snappy-java-1.1.7.3.jar
* Jackson
- jackson-module-parameter-names-2.10.0.jar
- jackson-module-parameter-names-2.11.1.jar
Expand Down
26 changes: 26 additions & 0 deletions pulsar-sql/presto-pulsar/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,32 @@
<version>${joda.version}</version>
</dependency>

<dependency>
<groupId>io.prestosql</groupId>
<artifactId>presto-record-decoder</artifactId>
<version>${presto.version}</version>
</dependency>

<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>pulsar-client-original</artifactId>
<version>${project.version}</version>
</dependency>
Comment on lines +110 to +114

@gaoran10 gaoran10 Nov 30, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this dependency is necessary?

@hnail hnail Dec 23, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes , PulsarRowDecoder.decodeRow() call GenericXXXSchema.decode(ByteBuf byteBuf) for GenericRecord.

@gaoran10 gaoran10 Jan 17, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the dependency pulsar-client-original is already in the pulsar-client-admin-original.


<dependency>
<groupId>io.prestosql</groupId>
<artifactId>presto-main</artifactId>
<version>${presto.version}</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.prestosql</groupId>
<artifactId>presto-testing</artifactId>
<version>${presto.version}</version>
<scope>test</scope>
</dependency>

</dependencies>

<build>
Expand Down
101 changes: 0 additions & 101 deletions pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/AvroSchemaHandler.java
View file
Open in desktop

This file was deleted.

108 changes: 0 additions & 108 deletions pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/JSONSchemaHandler.java
View file
Open in desktop

This file was deleted.

105 changes: 0 additions & 105 deletions ...r-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/KeyValueSchemaHandler.java
View file
Open in desktop

This file was deleted.

Loading