Skip to content

Enable pulsar function to send message to external pulsar cluster - #8434

Merged
codelipenghui merged 5 commits into
apache:masterfrom
streamnative:neng/function-output-clusters
Nov 21, 2020
Merged

Enable pulsar function to send message to external pulsar cluster#8434
codelipenghui merged 5 commits into
apache:masterfrom
streamnative:neng/function-output-clusters

Conversation

@nlu90

@nlu90 nlu90 commented Nov 2, 2020

Copy link
Copy Markdown
Member

Motivation

Enable pulsar function to send message to external pulsar cluster

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

@sijie sijie added area/function doc-required Your PR changes impact docs and you will update later. labels Nov 4, 2020
Signed-off-by: xiaolong.ran <rxl@apache.org>
Signed-off-by: xiaolong.ran <rxl@apache.org>
Signed-off-by: xiaolong.ran <rxl@apache.org>
@wolfstudy
wolfstudy marked this pull request as ready for review November 17, 2020 05:20
@wolfstudy wolfstudy changed the title enable pulsar function to send message to external pulsar cluster Enable pulsar function to send message to external pulsar cluster Nov 17, 2020
Signed-off-by: xiaolong.ran <rxl@apache.org>
@sijie sijie added this to the 2.7.0 milestone Nov 20, 2020

@wolfstudy wolfstudy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@liangyuanpeng

liangyuanpeng commented Sep 7, 2021

Copy link
Copy Markdown
Contributor

This PR revert by #10843 , So you cant not found some code or param like --external-pulsars.

@momo-jun

Copy link
Copy Markdown
Contributor

@Anonymitaet This PR has been reverted. So we can remove the doc-required label. Thank you.

@Anonymitaet Anonymitaet added doc-not-needed Your PR changes do not impact docs and removed doc-required Your PR changes impact docs and you will update later. labels Jun 27, 2022
@Anonymitaet

Copy link
Copy Markdown
Member

@momo-jun OK, removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/function doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants