Skip to content

[Bouncy Castle] include bc into pulsar-client fix docs - #8491

Merged
sijie merged 1 commit into
apache:masterfrom
jiazhai:fix_bc_after_7453
Nov 10, 2020
Merged

[Bouncy Castle] include bc into pulsar-client fix docs#8491
sijie merged 1 commit into
apache:masterfrom
jiazhai:fix_bc_after_7453

Conversation

@jiazhai

@jiazhai jiazhai commented Nov 9, 2020

Copy link
Copy Markdown
Member

Motivation

The docs of bc need an update after merge PR #7453, also we could include bc in the pulsar client to avoid reference it in other modules.

Modifications

  • fix the docs after fix PR 7453;
  • make pulsar client include bc module; avoid other modules to include bc.
  • fix the pulsar-function bc jar issue.

Verifying this change

all the tests passed.

@jiazhai

jiazhai commented Nov 10, 2020

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

1 similar comment
@jiazhai

jiazhai commented Nov 10, 2020

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

@jiazhai jiazhai added this to the 2.7.0 milestone Nov 10, 2020

@zymap zymap left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sijie
sijie merged commit 134f2aa into apache:master Nov 10, 2020
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this pull request Nov 17, 2020
### Motivation
The docs of bc need an update after merge PR apache#7453, also we could include bc in the pulsar client to avoid reference it in other modules.

### Modifications

- fix the docs after fix PR 7453;
- make pulsar client include bc module; avoid other modules to include bc.
- fix the pulsar-function bc jar issue.

### Verifying this change
all the tests passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants