[WIP] Remove Python 2 support for Python client - #8624
Closed
BewareMyPower wants to merge 4 commits into
Closed
Conversation
BewareMyPower
changed the title
BewareMyPower
force-pushed
the
bewaremypower/remove-python2
branch
from
February 11, 2021 06:53
d74829c to
ee2af5a
Compare
Contributor
Author
|
I'll open a new PR to do this work in future. |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #8622
Motivation
According to PIP 56, Python 2 should not be supported anymore. But the CMakeLists.txt still try to find include directory and library of Python 2.7 and the vagrant build script still build wheels for Python 2.
Modifications
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.