Fix the metadata setup compatibility issue - #8959
Merged
Merged
Conversation
--- *Motivation* For keeping the compatibility of the setup metadata command. We should avoid delete the existing arguments. If we need to change it, it's better to keep the old arguments and mark it deprecate and hide it.
Member
Author
|
/pulsarbot run-failure-checks |
eolivelli
reviewed
Dec 15, 2020
eolivelli
left a comment
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
Can we add unit tests in order to prevent regressions?
eolivelli
requested changes
Dec 15, 2020
| @@ -115,6 +115,13 @@ private static class Arguments { | |||
| description = "The metadata service URI of the existing BookKeeper cluster that you want to use") | |||
| private String existingBkMetadataServiceUri; | |||
|
|
|||
Contributor
There was a problem hiding this comment.
This annotation is not really meaningful here by itself, can we add a comment?
Member
Author
There was a problem hiding this comment.
Which annotation? Do you mean @Deprecated?
codelipenghui
approved these changes
Dec 16, 2020
sijie
approved these changes
Dec 16, 2020
sijie
added
the
doc-required
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2020
--- *Motivation* metadata command is not compatible with old versions. For keeping the compatibility of the setup metadata command, we should avoid deleting the existing arguments. If we need to change it, it's better to keep the old arguments and mark it deprecates and hide them. (cherry picked from commit d7da7af)
zymap
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Dec 21, 2020
--- *Motivation* metadata command is not compatible with old versions. For keeping the compatibility of the setup metadata command, we should avoid deleting the existing arguments. If we need to change it, it's better to keep the old arguments and mark it deprecates and hide them. (cherry picked from commit d7da7af)
Contributor
|
@zymap @sijie I don't think we need to add
|
Member
Author
|
Yes. I think we can remove the |
zymap
removed
the
doc-required
Contributor
|
@zymap thank you for your confirmation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#8269 change the arguments name which causes the setup
metadata command is not compatible with old versions.
For keeping the compatibility of the setup metadata command,
we should avoid deleting the existing arguments. If we need to
change it, it's better to keep the old arguments and mark it
deprecates and hide them.