fix ConcurrentModificationException - #9088
Merged
Merged
Conversation
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
eolivelli
approved these changes
Dec 30, 2020
eolivelli
left a comment
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
Lgtm
Do we have tests that start a broker with two topics and reproduce the error?
jiazhai
approved these changes
Dec 30, 2020
Member
|
@aloyszhang . it would be better to have a test as enrico mentioned to protect this part of code. |
Contributor
Author
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Dec 30, 2020
Contributor
Author
|
/pulsarbot run-failure-checks |
2 similar comments
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
2 similar comments
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
@eolivelli This problem is exactly caused by delete element while traversing the HashSet for single topic |
Contributor
Author
|
/pulsarbot run-failure-checks |
2 similar comments
Member
|
/pulsarbot run-failure-checks |
Member
|
/pulsarbot run-failure-checks |
Contributor
|
@aloyszhang please rebase the master branch |
Contributor
Author
|
/pulsarbot run-failure-checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9087
Motivation
This PR fix the ConcurrentModificationException when broker start with kop enabled.