Initial python 3.9 client wheel build support - #9389
Merged
Conversation
In a clean environment, this script can incorrectly fail in two places: * Add `-r` to xargs to avoid running command if find doesn't return anything * Add `-f` to rm to silent to avoid failure if nothing to rm
* Wrong var name `IMAGE` instead of `IMAGE_NAME` * Added python 3.9 version
* Added py39 versions to remaining build scripts * Also for cmake, updated `pulsar-client-cpp/python/CMakeLists.txt`
vkvm
changed the title
zymap
requested review from
aahmed-se,
codelipenghui,
merlimat,
sijie and
tuteng
February 1, 2021 03:50
Member
|
Hi, @BewareMyPower could you please take a look at this? |
aahmed-se
approved these changes
Feb 1, 2021
BewareMyPower
approved these changes
Feb 1, 2021
Contributor
|
/pulsar-bot run-failure-tests |
Member
|
@vkvm thanks for the work. would you please help open a new issue to track the later change for the document? |
Contributor
Author
sijie
added
the
doc-required
sijie
approved these changes
Feb 2, 2021
Added python 3.9 support to `pulsar-client-cpp/docker/push-images.sh` Presumably this is used by someone with push access to the `apachepulsar` docker registry, so it's not something I've actually tested.
Contributor
|
Hi @vkvm, is there any chance that you could revisit this PR for doc updates? |
Contributor
|
@momo-jun I think we don't need the doc updates now. These wheels should only be built by GitHub Actions now. |
Contributor
|
@BewareMyPower Thanks for your information. Good to know that! I will refresh the doc status label. |
momo-jun
added
doc-not-needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-client-lib-within-docker.shbuild-client-lib.shand add py39Motivation
A python 3.9 client wheel is missing. This is an initial attempt to add it. I'm mainly concerned about Fedora + RHEL7.
Modifications
Mostly just fixing up / modifying build scripts used with docker.
I don't know enough about the build system. I made sufficient changes for me to
be able to do this (roughly):
When I built the wheel on my laptop, I commented out all other versions or
specified just 3.9.
TODO: Documentation
As a new user, it was confusing figuring out how exactly to build this. I can take a quick stab at doc updates after this is merged.