Expire message by position. - #9514
Merged
codelipenghui merged 4 commits intoFeb 10, 2021
Merged
Conversation
codelipenghui
requested review from
315157973,
codelipenghui,
hangc0276,
jiazhai,
merlimat,
sijie and
zymap
February 7, 2021 06:44
Contributor
|
/pulsarbot run-failure-checks |
eolivelli
reviewed
Feb 7, 2021
zymap
reviewed
Feb 8, 2021
codelipenghui
requested changes
Feb 8, 2021
315157973
reviewed
Feb 8, 2021
codelipenghui
approved these changes
Feb 10, 2021
codelipenghui
added
cherry-picked/branch-2.7
codelipenghui
pushed a commit
that referenced
this pull request
Feb 18, 2021
Fixes #2736 Add ability to expire message for subscription by position to admin client and admin rest API. Update PersistentMessageExpiryMonitor to able to expire message by position and expose to admin client and admin rest api. This change added tests and can be verified as follows: - Added unit test for expire message by position in PersistentMessageFinderTest. - Added test for expire message by position in admin client/admin rest api. (cherry picked from commit 301d42c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2736
Motivation
Add ability to expire message for subscription by position to admin client and admin rest API.
Modifications
Update PersistentMessageExpiryMonitor to able to expire message by position and expose to admin client and admin rest api.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
Documentation