add Deposit-Solutions - #9593
Closed
pointearth wants to merge 1 commit into
Closed
Conversation
sijie
approved these changes
Feb 16, 2021
Member
|
@pointearth Thank you for your contribution! Glad to see more companies adopting Pulsar! |
codelipenghui
approved these changes
Feb 16, 2021
Contributor
|
@pointearth Seem the changes are not based on the latest master branch, could you please rebase to the master branch? So that the CI can works. |
Member
|
@codelipenghui This CI is not running due to #9527. I reverted the changes in #9606. Please review it and let's get the change merged first to unblock CI. |
Contributor
|
@pointearth Sorry, I want to close the PR and reopen it to trigger the CI, but I don't know why I can't reopen it. |
Contributor
|
I merged #9604 first since the CI passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation