[Tests] Use DiagnosticCommand JMX MBean to do the threaddump - #9766
Merged
Conversation
lhotari
force-pushed
the
lh-improve-thread-dumps
branch
from
March 1, 2021 17:38
b493948 to
5423f39
Compare
merlimat
approved these changes
Mar 1, 2021
eolivelli
reviewed
Mar 1, 2021
- improve threaddump by using DiagnosticCommand JMX MBean to do the threaddump - include full information about locks in the output - fallback to previous method if DiagnosticCommand MBean fails to produce the threaddump
lhotari
force-pushed
the
lh-improve-thread-dumps
branch
from
March 2, 2021 06:34
5423f39 to
4f10965
Compare
lhotari
changed the title
Member
Author
|
/pulsarbot run-failure-checks |
Contributor
|
/pulsarbot run-failure-checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a tests times out, a thread dump will be printed using
org.apache.pulsar.tests.ThreadDumpUtil. This class produces output that isn'tas rich as the output of
jstack -l <pid>. However it's possible to produce a similar thread dump in Java programmatically. The benefit of a richer and standard thread dump is that it's possible to analyse it using standard tooling such as https://jstack.review/Modifications
jstack -l <pid>producesthe threaddump