[WIP] [fix #9640] fix pulsar-client-admin-api dependency - #9842
Closed
freeznet wants to merge 3 commits into
Closed
Conversation
merlimat
reviewed
Mar 9, 2021
| <version>${project.parent.version}</version> | ||
| <groupId>com.google.code.gson</groupId> | ||
| <artifactId>gson</artifactId> | ||
| <scope>provided</scope> |
Contributor
There was a problem hiding this comment.
This API package shouldn't depend on anything more than pulsar-client-api.
Having the dependencies marked as "provided" doesn't really fix the issue because the implementation will still be using them. We should instead make sure that the POJOs are not using any other dependency.
Contributor
Author
There was a problem hiding this comment.
yea, thanks for your comment. will update the pr once done.
freeznet
force-pushed
the
freeznet/fix-admin-api-dependency
branch
from
March 10, 2021 15:01
d40b445 to
636e6d1
Compare
Contributor
|
@freeznet what is the status of this work? |
1 task
Contributor
Author
|
close this PR and addressed the issue with PR #10513. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9640
Motivation
Module
pulsar-client-admin-apihas been introduced in #9246, but it pulling in many dependencies. That is undesirable for an "API" module. As @sijie @merlimat and @jerrypeng suggests, this pr resolves the issue and makepulsar-client-admin-apihas minimal transient dependences.Modifications
Verifying this change
pulsar-client-admin-apiwith minimal transient dependences.Changes need to confirm
org.apache.pulsar.common.api.proto.CommandSubscribe.SubType, I have changed the type fromSubTypetoStringinpulsar-client-admin-apimodule. [DONE]PulsarAdmin#getClientConfigData()returnsClientConfigurationDatafromorg.apache.pulsar.client.impl.conf, which will cause unnecessary dependency topulsar-client-original. [WIP]