[Admin CLI]Add admin rest endpoint/CLI to trim ledgers for a topic upon given position. - #9929
Closed
MarvinCai wants to merge 4 commits into
Closed
[Admin CLI]Add admin rest endpoint/CLI to trim ledgers for a topic upon given position.#9929MarvinCai wants to merge 4 commits into
MarvinCai wants to merge 4 commits into
Conversation
Contributor
Author
|
@sijie Please take a look. |
sijie
requested review from
315157973,
codelipenghui,
hangc0276,
jiazhai,
merlimat and
zymap
March 17, 2021 04:54
Contributor
|
The pr had no activity for 30 days, mark with Stale label. |
|
@MarvinCai:Thanks for your contribution. For this PR, do we need to update docs? |
Member
|
The issue to be fixed was fixed by #10326. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2736
Motivation
Able to set infinite retention on a namespace and then manually truncate the topic.
Modifications
In ManagedLedgerImpl, expose api to delete ledger upon given position.
Add Admin rest endpoint and CLI for this functionality.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation