Skip to content

Conversation

@szetszwo
Copy link
Contributor

See RATIS-1987.

The test client should enqueue before calling onNext(..).
After this change, passed 100 times: https://github.com/szetszwo/ratis/actions/runs/7532901374

@szetszwo szetszwo requested a review from adoroszlai January 15, 2024 19:56
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szetszwo for the patch, LGTM.

Should the same fix be applied to helloReplies?

final CompletableFuture<String> f = new CompletableFuture<>();
try {
helloRequestHandler.onNext(request);
helloReplies.offer(f);
} catch (IllegalStateException e) {
// already closed
f.completeExceptionally(e);
}

@szetszwo
Copy link
Contributor Author

@adoroszlai , Thanks for reviewing this! Yes, we should also fix helloReplies.

@szetszwo szetszwo merged commit 863c2e8 into apache:master Jan 15, 2024
symious pushed a commit to symious/ratis that referenced this pull request Apr 4, 2024
SzyWilliam pushed a commit to SzyWilliam/ratis that referenced this pull request Jun 12, 2024
szetszwo added a commit to szetszwo/ratis that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants