RATIS-2003. Fix IT_NO_SUCH_ELEMENT in InstallSnapshotRequests #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
reviewed
Jan 17, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@adoroszlai Thanks a lots for working on this!
Let's take this chance to move the iterator code to an inner class; see https://issues.apache.org/jira/secure/attachment/13066117/1016_review.patch
Contributor
Author
Thanks @szetszwo for the review. I agree that extracting to inner class improves the code. There is one piece from the review patch that I omitted: extracting the |
szetszwo
approved these changes
Jan 18, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Apr 4, 2024
SzyWilliam
pushed a commit
to SzyWilliam/ratis
that referenced
this pull request
Jun 12, 2024
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove
@SuppressFBWarnings("IT_NO_SUCH_ELEMENT")inInstallSnapshotRequests, and ensure spotbugs does not complain.https://issues.apache.org/jira/browse/RATIS-2003
How was this patch tested?
CI:
https://github.com/adoroszlai/ratis/actions/runs/7562098256