RATIS-2007. Zero-copy buffers are not released #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@szetszwo Please have a look. |
szetszwo
reviewed
Jan 25, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@duongkame , thanks for working on this! Just have a comment inlined.
Comment on lines
885
to
886
| final RaftClientReply reply = newExceptionReply(request, e); | ||
| requestRef.release(); | ||
| final RaftClientReply reply = newExceptionReply(request, e); |
Contributor
There was a problem hiding this comment.
The original order (newExceptionReply -> release) seems better since request is used in newExceptionReply.
Contributor
Author
There was a problem hiding this comment.
Right, I made that change my mistake.
szetszwo
approved these changes
Jan 25, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When running tests as per #1023, some buffer leaks are discovered.
ReferenceCountedObjectreleaseinwhenComplete(e.g.RaftServerImpl'ssubmitClientRequestAsyncandappendEntriesAsync) does not always guarantee an execution. As the retuned future may be discarded when the client connection is terminated.processClientRequestcalled from SlidingWindow doesn't always guarantee 100% execution either.PendingOrderedRequestentries may not be processed at all because of client cancellation, or request duplications (IllegalStateExceptiondue to retries.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2007
How was this patch tested?
Tests.