Skip to content

RATIS-2047 Avoid unnecessary warn log when creating raft group #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szetszwo merged 1 commit into from
Mar 22, 2024
Merged

RATIS-2047 Avoid unnecessary warn log when creating raft group #1054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions ratis-server/src/main/java/org/apache/ratis/server/storage/RaftStorageImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

import java.io.InputStream;
import java.io.OutputStream;
import java.nio.file.NoSuchFileException;
import java.util.concurrent.atomic.AtomicReference;
import org.apache.ratis.proto.RaftProtos.LogEntryProto;
import org.apache.ratis.server.RaftConfiguration;
Expand Down Expand Up @@ -153,14 +152,16 @@ public void writeRaftConfiguration(LogEntryProto conf) {

public RaftConfiguration readRaftConfiguration() {
File confFile = storageDir.getMetaConfFile();
try (InputStream fio = FileUtils.newInputStream(confFile)) {
LogEntryProto confProto = LogEntryProto.newBuilder().mergeFrom(fio).build();
return LogProtoUtils.toRaftConfiguration(confProto);
} catch (FileNotFoundException | NoSuchFileException e) {
return null;
} catch (Exception e) {
LOG.error("Failed reading configuration from file:" + confFile, e);
if (!confFile.exists()) {
return null;
} else {
try (InputStream fio = FileUtils.newInputStream(confFile)) {
LogEntryProto confProto = LogEntryProto.newBuilder().mergeFrom(fio).build();
return LogProtoUtils.toRaftConfiguration(confProto);
} catch (Exception e) {
LOG.error("Failed reading configuration from file:" + confFile, e);
return null;
}
}
}

Expand Down