RATIS-1504. Add timeout handling to DataStreamManagement#checkSuccessRemoteWrite. #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| final TimeDuration timeout = isClose ? closeTimeout : requestTimeout; | ||
| replyEntry.scheduleTimeout(() -> channel.eventLoop().schedule(() -> { |
Contributor
There was a problem hiding this comment.
Thanks @szetszwo work on this. I think about this part of the code like this:
After the client sends successfully, then wait for the server's reply, the timeout time is to detect the timeout of the server's reply, so I start the timeout listener after the client sends the request successfully. So I started the timeout listener after the client sent the request successfully, and canceled the timeout listener after the server replyed successfully.
Contributor
Author
There was a problem hiding this comment.
I see. Then, let's keep the previous logic.
Contributor
|
+1 LGTM. |
guohao-rosicky
approved these changes
Apr 12, 2024
Contributor
Author
|
@guohao-rosicky , thanks a lot for reviewing and merging this! |
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Apr 16, 2024
…RemoteWrite. (apache#1064) * RATIS-1504. Add timeout handling to DataStreamManagement#checkSuccessRemoteWrite.
szetszwo
added a commit
to szetszwo/ratis
that referenced
this pull request
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See RATIS-1504