Skip to content

RATIS-2101. Move TermIndex.PRIVATE_CACHE to Util.CACHE #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szetszwo merged 1 commit into from
May 25, 2024
Merged

RATIS-2101. Move TermIndex.PRIVATE_CACHE to Util.CACHE #1103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions ratis-server-api/src/main/java/org/apache/ratis/server/protocol/TermIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,14 @@

/** The term and the log index defined in the Raft consensus algorithm. */
public interface TermIndex extends Comparable<TermIndex> {
/** An LRU Cache for {@link TermIndex} instances */
Cache<TermIndex, TermIndex> PRIVATE_CACHE = CacheBuilder.newBuilder()
.maximumSize(1 << 16)
.expireAfterAccess(1, TimeUnit.MINUTES)
.build();
class Util {
/** An LRU Cache for {@link TermIndex} instances */
private static final Cache<TermIndex, TermIndex> CACHE = CacheBuilder.newBuilder()
.maximumSize(1 << 16)
.expireAfterAccess(1, TimeUnit.MINUTES)
.build();
}
TermIndex[] EMPTY_ARRAY = {};

/** @return the term. */
long getTerm();
Expand Down Expand Up @@ -107,7 +110,7 @@ public String toString() {
}
};
try {
return PRIVATE_CACHE.get(key, () -> key);
return Util.CACHE.get(key, () -> key);
} catch (ExecutionException e) {
throw new IllegalStateException("Failed to valueOf(" + term + ", " + index + "), key=" + key, e);
}
Expand Down