RATIS-2289. Coverage is 0% due to no execution data files provided #1255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Calculated coverage is 0% because input files are missing.
https://github.com/apache/ratis/actions/runs/14887012940/job/41810202866#step:7:1977
The problem is re-definition of
WITH_COVERAGEvariable inunitjob. Originallywith-coveragewas supposed to be a workflow input, but it was removed.This change:
WITH_COVERAGEdepending on whether the workflow is triggered bypushorpull_reqestcoveragein forks (to exercisecoverage.shand allow checking coverage results before merging toapache/ratis)sonar.shin forks (since token required for uploading to Sonar Qube is only available inapache/ratis)https://issues.apache.org/jira/browse/RATIS-2289
How was this patch tested?
https://github.com/adoroszlai/ratis/actions/runs/14913776473/job/41895151947#step:7:1967
Downloaded
coverage.zipand verified coverage is > 0% inall/index.html.