when the client host have more than 2 ip address, the ClientConfig get the last one ipv4 always. It will make some unpredictable result.#41
Closed
tain198127 wants to merge 18 commits into
Closed
Conversation
Additionally, added code comments and did a cleanup. JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-13
… more works, thanks @Jaskey*
…ip。那么可能会造成性能下降或者无法联通。虽然可以使用 setClientIP方法来解决这个问题。但是处理太过硬性。在集群环境中会对部署造成很大压力。 修改增加了可以通过过滤来取得正确的地址的方法。
Contributor
|
Please follow instructions here. |
Member
|
IMO, this feature is not necessary, clientIP is only used in bornHost. |
Member
|
Hi @tain198127, could you please use English in the pr title and commit logs? Also please refer to here and here before sending a pull request to RocketMQ. |
Member
|
@tain198127 Could you follow other PR[1] style at first ? [1] #5 |
tain198127
changed the title
…ketmq # Conflicts: # broker/src/test/java/org/apache/rocketmq/broker/BrokerControllerTest.java # rocketmq-store/src/test/resources/logback-test.xml # store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java # store/src/main/java/org/apache/rocketmq/store/ha/HAService.java # store/src/main/java/org/apache/rocketmq/store/index/IndexService.java # store/src/test/java/org/apache/rocketmq/store/MappedFileQueueTest.java # store/src/test/java/org/apache/rocketmq/store/index/IndexFileTest.java
get lastest version from apache rocket
This reverts commit 2892a77.
This reverts commit df9d621.
Member
|
please follow us PR guide, modify your topic and ensure all testing validity |
lizhanhui
pushed a commit
to lizhanhui/rocketmq
that referenced
this pull request
Jun 25, 2019
lizhanhui
pushed a commit
to lizhanhui/rocketmq
that referenced
this pull request
Jun 25, 2019
pingww
pushed a commit
that referenced
this pull request
Aug 26, 2022
Increase test case and improve code coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the client to start the producer, the producer will use the last one ipv4 address as default ip.but if the os have more than one ipv4 address, it will get some unexpected result.
Although ClientConfig provide a method setClientIP to avoid this issue, but in production environment with cluster ,every producer need to set a ip address, it will make some mistake.