[ROCKETMQ-99] Add scripts for Windows#62
Closed
lizhanhui wants to merge 9 commits into
Closed
Conversation
2 similar comments
2 similar comments
2 similar comments
1 similar comment
zhouxinyu
approved these changes
Feb 24, 2017
zhouxinyu
left a comment
zhouxinyu
left a comment
Member
There was a problem hiding this comment.
LGTM, please @vongosling help review.
Member
|
@lizhanhui Cool. Did you check the commits, letting all passed in at least 2 windows environment ? |
Contributor
Author
|
@vongosling I plan to install a Windows XP on a virtual machine if there is no feedback from community. Actually, I am hoping someone may test this PR on Windows 10 which covers majority of windows users. |
Member
|
I am hoping someone may test this PR on Windows 10 which covers majority of windows users. Yep agreed. |
asfgit
pushed a commit
that referenced
this pull request
Feb 28, 2017
Member
|
@lizhanhui Done for dev. branch ~ Could you close this PR? |
Contributor
Author
|
All right. |
asfgit
pushed a commit
that referenced
this pull request
Jun 6, 2017
JiaMingLiu93
pushed a commit
to JiaMingLiu93/rocketmq
that referenced
this pull request
May 28, 2020
JiaMingLiu93
pushed a commit
to JiaMingLiu93/rocketmq
that referenced
this pull request
May 28, 2020
pingww
pushed a commit
that referenced
this pull request
Aug 26, 2022
Co-authored-by: AhaThinking <ahathinking@SK-20211027RHLU.mioffice.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add scripts for windows where possible.