[ROCKETMQ-32] Improve concision - Reuse local variable 'brokerAddrs' in RouteInfoManager.getSystemTopicList method#8
[ROCKETMQ-32] Improve concision - Reuse local variable 'brokerAddrs' in RouteInfoManager.getSystemTopicList method#8zhaozhanh wants to merge 25 commits into
Conversation
|
Hi @naughtybear, Thanks your PR, could you abide our PR process(modify your PR subject and mention your jira address in the description), please follow this PR. #5 |
|
Hi @zhouxinyu , Sorry. Code concision improvement. |
|
please modify you PR subject and fix conflict problems. |
|
All done. |
|
Subject still is "simplify if grammar "?please bind with JIRA. You can refer to other PR:-) |
zhaozhanh
changed the title
|
Could you polish again just like other PR. such as title start with JIRA issues. The following links may be helpful for you. http://rocketmq.incubator.apache.org/docs/pull-request/ |
…aceUsedPercent(), closes #23
|
@vongosling
Am I right? If so, I need start a new pull request and modify JIRA info to keep aligned. |
|
Yes, do not start a new pull request.Just modify your topic, start a JIRA and bind them :-) |
zhaozhanh
changed the title
|
@vongosling Is that be Ok? |
|
It seems ok, thanks @naughtybear . Please @vongosling @lizhanhui help review it. |
|
@vongosling @lizhanhui |
| while (it.hasNext()) { | ||
| BrokerData bd = brokerAddrTable.get(it.next()); | ||
| HashMap<Long, String> brokerAddrs = bd.getBrokerAddrs(); | ||
| if (bd.getBrokerAddrs() != null && !bd.getBrokerAddrs().isEmpty()) { |
|
alright |
…is not exist [ISSUE #8] fix rocketmq-mqtt check style error and .travis.yaml file is not exist
8 participants
reuse brokerAddrs, or change like following:
if (bd.getBrokerAddrs() != null && !bd.getBrokerAddrs().isEmpty()) { Iterator<Long> it2 = bd.getBrokerAddrs().keySet().iterator(); topicList.setBrokerAddr(bd.getBrokerAddrs().get(it2.next())); break; }