[ROCKETMQ-121]Support message filtering based on SQL92 #82
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.rocketmq.broker.client; | ||
|
|
||
| public enum ConsumerGroupEvent { | ||
|
|
||
| /** | ||
| * Some consumers in the group are changed. | ||
| */ | ||
| CHANGE, | ||
| /** | ||
| * The group of consumer is unregistered. | ||
| */ | ||
| UNREGISTER, | ||
| /** | ||
| * The group of consumer is registered. | ||
| */ | ||
| REGISTER | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.rocketmq.broker.filter; | ||
|
|
||
| import org.apache.rocketmq.common.BrokerConfig; | ||
| import org.apache.rocketmq.common.constant.LoggerName; | ||
| import org.apache.rocketmq.filter.util.BitsArray; | ||
|
Member
There was a problem hiding this comment. BitMap ? Could we use the roaring bitmap, https://github.com/RoaringBitmap/RoaringBitmap |
||
| import org.apache.rocketmq.store.CommitLogDispatcher; | ||
| import org.apache.rocketmq.store.DispatchRequest; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import java.util.Collection; | ||
| import java.util.Iterator; | ||
|
|
||
| /** | ||
| * Calculate bit map of filter. | ||
| */ | ||
| public class CommitLogDispatcherCalcBitMap implements CommitLogDispatcher { | ||
|
|
||
| private static final Logger log = LoggerFactory.getLogger(LoggerName.FILTER_LOGGER_NAME); | ||
|
|
||
| protected final BrokerConfig brokerConfig; | ||
| protected final ConsumerFilterManager consumerFilterManager; | ||
|
|
||
| public CommitLogDispatcherCalcBitMap(BrokerConfig brokerConfig, ConsumerFilterManager consumerFilterManager) { | ||
| this.brokerConfig = brokerConfig; | ||
| this.consumerFilterManager = consumerFilterManager; | ||
| } | ||
|
|
||
| @Override | ||
| public void dispatch(DispatchRequest request) { | ||
| if (!this.brokerConfig.isEnableCalcFilterBitMap()) { | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
|
|
||
| Collection<ConsumerFilterData> filterDatas = consumerFilterManager.get(request.getTopic()); | ||
|
|
||
| if (filterDatas == null || filterDatas.isEmpty()) { | ||
| return; | ||
| } | ||
|
|
||
| Iterator<ConsumerFilterData> iterator = filterDatas.iterator(); | ||
| BitsArray filterBitMap = BitsArray.create( | ||
| this.consumerFilterManager.getBloomFilter().getM() | ||
| ); | ||
|
|
||
| long startTime = System.currentTimeMillis(); | ||
| while (iterator.hasNext()) { | ||
| ConsumerFilterData filterData = iterator.next(); | ||
|
|
||
| if (filterData.getCompiledExpression() == null) { | ||
| log.error("[BUG] Consumer in filter manager has no compiled expression! {}", filterData); | ||
| continue; | ||
| } | ||
|
|
||
| if (filterData.getBloomFilterData() == null) { | ||
| log.error("[BUG] Consumer in filter manager has no bloom data! {}", filterData); | ||
| continue; | ||
| } | ||
|
|
||
| Object ret = null; | ||
| try { | ||
| MessageEvaluationContext context = new MessageEvaluationContext(request.getPropertiesMap()); | ||
|
|
||
| ret = filterData.getCompiledExpression().evaluate(context); | ||
| } catch (Throwable e) { | ||
| log.error("Calc filter bit map error!commitLogOffset={}, consumer={}, {}", request.getCommitLogOffset(), filterData, e); | ||
| } | ||
|
|
||
| log.debug("Result of Calc bit map:ret={}, data={}, props={}, offset={}", ret, filterData, request.getPropertiesMap(), request.getCommitLogOffset()); | ||
|
|
||
| // eval true | ||
| if (ret != null && ret instanceof Boolean && (Boolean) ret) { | ||
| consumerFilterManager.getBloomFilter().hashTo( | ||
| filterData.getBloomFilterData(), | ||
| filterBitMap | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| request.setBitMap(filterBitMap.bytes()); | ||
|
|
||
| long eclipseTime = System.currentTimeMillis() - startTime; | ||
| // 1ms | ||
| if (eclipseTime >= 1) { | ||
| log.warn("Spend {} ms to calc bit map, consumerNum={}, topic={}", eclipseTime, filterDatas.size(), request.getTopic()); | ||
| } | ||
| } catch (Throwable e) { | ||
| log.error("Calc bit map error! topic={}, offset={}, queueId={}, {}", request.getTopic(), request.getCommitLogOffset(), request.getQueueId(), e); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactoring