[ROCKETMQ-187]Measure the code coverage for Integration Tests, and add sonar-apache profile#96
Closed
dongeforever wants to merge 1 commit into
Closed
[ROCKETMQ-187]Measure the code coverage for Integration Tests, and add sonar-apache profile#96dongeforever wants to merge 1 commit into
dongeforever wants to merge 1 commit into
Conversation
Member
Author
|
@lizhanhui @zhouxinyu @vongosling please have a review |
2 similar comments
Member
|
LGTM |
Member
Author
|
The PR is better not to be merged by the original author. |
asfgit
pushed a commit
that referenced
this pull request
May 9, 2017
…dd sonar-apache profile, closes #96
Contributor
|
It's good and looks it's already been merged. |
asfgit
pushed a commit
that referenced
this pull request
Jun 6, 2017
…dd sonar-apache profile, closes #96
JiaMingLiu93
pushed a commit
to JiaMingLiu93/rocketmq
that referenced
this pull request
May 28, 2020
…dd sonar-apache profile, closes apache#96
JiaMingLiu93
pushed a commit
to JiaMingLiu93/rocketmq
that referenced
this pull request
May 28, 2020
…dd sonar-apache profile, closes apache#96
pingww
added a commit
that referenced
this pull request
Aug 26, 2022
[ISSUE #22] improving codeCov of mqtt.ds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/ROCKETMQ-187
Now we could browse the Unit Tests and IT Tests at
https://builds.apache.org/analysis/component_measures/?id=org.apache.rocketmq%3Arocketmq-all
But the IT Test coverage is not correct. It should cover the original sources instead of the the classes in test module.
As for as I known, the coverage report is generated by matching the collected data(often using java agent) against a set of classes (the module classes compiled from src/main/). you could refer to: http://olafsblog.sysbsb.de/measuring-test-coverage-of-integration-tests-for-separated-modules-with-jacoco/
So we could match the jacoco-it.exec to each module's source classes to get the correct IT coverage report.
By the way, we'd better exclude the classes in the test module.
we may use sonar locally.
So we'd better use profile to handle different occasions