Add cluster concept to the configuration, and enhance namespace concept#123
Merged
Conversation
* [Important] Add cluster concept, also as a part of service naming format. The cluster name would be
1. Add as {@link #SERVICE_NAME} suffix.
2. Add as exit span's peer, ${CLUSTER} / original peer
3. Cross Process Propagation Header's value addressUsedAtClient[index=8] (Target address of this request used on the
client end).
* [Breaking Change] Remove deprecated `agent.instance_properties` configuration.
Recommend `agent.instance_properties_json`.
* The namespace and cluster would be reported as instance properties, keys are `namespace` and `cluster`. Notice, if
instance_properties_json includes these two keys, they would be overrided by the agent core.
kezhenxu94
previously approved these changes
Mar 12, 2022
kezhenxu94
approved these changes
Mar 12, 2022
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.part of service naming format.
client end).
agent.instance_propertiesconfiguration.Recommend
agent.instance_properties_json.namespaceandcluster. Notice, ifinstance_properties_json includes these two keys, they would be overrided by the agent core.
cross process propagationkey.