Skip to content

Fix Reconnect when report has an exception occurs#105

Closed
dafu-wu wants to merge 1 commit into
apache:masterfrom
dafu-wu:hotfix
Closed

Fix Reconnect when report has an exception occurs#105
dafu-wu wants to merge 1 commit into
apache:masterfrom
dafu-wu:hotfix

Conversation

@dafu-wu

@dafu-wu dafu-wu commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@kezhenxu94

Copy link
Copy Markdown
Member

Hey @wuchengyi2006 , thanks! The exception should be caught here

try:
self.traces_reporter.report(generator())
except grpc.RpcError:
self.on_error()

which version are you using and what exception did you encounter that is not caught by 👆

@dafu-wu

dafu-wu commented Dec 18, 2020

Copy link
Copy Markdown
Contributor Author

Hey @wuchengyi2006 , thanks! The exception should be caught here

try:
self.traces_reporter.report(generator())
except grpc.RpcError:
self.on_error()

which version are you using and what exception did you encounter that is not caught by 👆

Great,My version maybe is too old,It seems that the problem has been solved!

@dafu-wu dafu-wu closed this Dec 18, 2020
@kezhenxu94

Copy link
Copy Markdown
Member

Thanks for confirmation

@kezhenxu94 kezhenxu94 added the duplicate This issue or pull request already exists label Dec 18, 2020
@kezhenxu94 kezhenxu94 added this to the 0.5.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants