Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .asf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,4 @@ github:
strict: true
contexts:
- CheckStatus
required_pull_request_reviews:
dismiss_stale_reviews: true
required_approving_review_count: 1
Comment on lines -38 to -40

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm removing this since trivial changes like this PR can be merged quickly as long as the checks passed

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about non-trivial changes ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about non-trivial changes ?

Committers can request reviews from other committers, as we have limited committers in this repo, I'd rather work on trust that we know the changes are non-trivial and need review

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can those people who are not members (committer/PMC) merge directly when the checks passed ? If they can't I think this change of .asf.yml is ok.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can those people who are not members (committer/PMC) merge directly when the checks passed ? If they can't I think this change of .asf.yml is ok.

Of course they can't, merging needs write access to the repo

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have no worries.


24 changes: 24 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,29 @@
## Change Logs

### 0.5.0

- New plugins
- Pyramid Plugin (#102)
- AioHttp Plugin (#101)
- Sanic Plugin (#91)

- API and enhancements
- `@trace` decorator supports `async` functions
- Supports async task context
- Optimized path trace ignore
- Moved exception check to `Span.__exit__`
- Moved Method & Url tags before requests

- Fixes:
- `BaseExceptions` not recorded as errors
- Allow pending data to send before exit
- `sw_flask` general exceptions handled
- Make `skywalking` logging Non-global

- Chores and tests
- Make tests really run on specified Python version
- Deprecate 3.5 as it's EOL

### 0.4.0

- Feature: Support Kafka reporter protocol (#74)
Expand Down