[Enhancement] Async task context support#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow async frameworks and apps to mostly work properly - where with only thread-local storage they could not as the individual async tasks would interfere with each other's context. A new task-local context is created on get_context() for each task and all subtasks inherit this to be able to correlate entry and exit spans.
This is not a complete and final solution as there will still be problems with a single entry point executing multiple async exit requests simultaneously. Also if a context is created BEFORE the async handler loop starts then all the handlers would share the same parent context, but this does not happen in Tornado.