Skip to content

[Enhancement] optimized path trace ignore#96

Merged
kezhenxu94 merged 1 commit into
apache:masterfrom
tom-pytel:master
Dec 9, 2020
Merged

[Enhancement] optimized path trace ignore#96
kezhenxu94 merged 1 commit into
apache:masterfrom
tom-pytel:master

Conversation

@tom-pytel

@tom-pytel tom-pytel commented Dec 9, 2020

Copy link
Copy Markdown
Contributor
  • Removed SW_TRACE_IGNORE and just using SW_TRACE_IGNORE_PATH to enable path trace ignore.
  • Optimized path ignore by merging path and suffix into a single regular expression test.
  • decorator.py exception wrapping not necessary because exceptions are checked in span.__exit__() on context exit.

@kezhenxu94 kezhenxu94 added the enhancement New feature or request label Dec 9, 2020
@kezhenxu94 kezhenxu94 added this to the 0.5.0 milestone Dec 9, 2020
kezhenxu94
kezhenxu94 approved these changes Dec 9, 2020
View reviewed changes

@kezhenxu94 kezhenxu94 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kezhenxu94 kezhenxu94 merged commit eca37b8 into apache:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tom-pytel @kezhenxu94