harden e2e test by adding healthCheck - #10
Conversation
Signed-off-by: tison <wander4096@gmail.com>
0cae865 to
8ccac6d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 85.15% 85.15%
=======================================
Files 9 9
Lines 283 283
=======================================
Hits 241 241
Misses 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Shikugawa @wu-sheng I think the tests is somehow stable and you can review that whether the change is valid. |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Shikugawa
left a comment
There was a problem hiding this comment.
Overall LGTM. A nit comment.
|
This PR is very helpful and worth doing to implement other agent implementations using the same mechanism on regression tests, such as cpp2sky. |
Signed-off-by: tison <wander4096@gmail.com>
416719c to
662f499
Compare
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
|
@Shikugawa @wu-sheng this PR is ready for review. |
|
@Shikugawa thanks for your review! You may clean up the squash commit message the next time. I think most of them are meaningless. Or you can ask me to do the squash :P |
Signed-off-by: tison wander4096@gmail.com
... according to #9 (comment).
This is a draft PR and I submit it for running tests. I'll set it as ready for review after validation.