Skip to content

harden e2e test by adding healthCheck - #10

Merged
Shikugawa merged 10 commits into
apache:masterfrom
tisonkun:e2e-liveness-probe
Jan 22, 2022
Merged

harden e2e test by adding healthCheck#10
Shikugawa merged 10 commits into
apache:masterfrom
tisonkun:e2e-liveness-probe

Conversation

@tisonkun

Copy link
Copy Markdown
Member

Signed-off-by: tison wander4096@gmail.com

... according to #9 (comment).

This is a draft PR and I submit it for running tests. I'll set it as ready for review after validation.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@codecov-commenter

codecov-commenter commented Jan 21, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.15%. Comparing base (f4743a9) to head (a647136).
⚠️ Report is 62 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   85.15%   85.15%           
=======================================
  Files           9        9           
  Lines         283      283           
=======================================
  Hits          241      241           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
tisonkun marked this pull request as ready for review January 21, 2022 13:06
@tisonkun

Copy link
Copy Markdown
Member Author

@Shikugawa @wu-sheng I think the tests is somehow stable and you can review that whether the change is valid.

Comment thread .github/workflows/e2e.yml Outdated
@wu-sheng wu-sheng added this to the 0.1.0 milestone Jan 21, 2022
@wu-sheng
wu-sheng requested a review from kezhenxu94 January 21, 2022 13:08
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>

@Shikugawa Shikugawa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. A nit comment.

Comment thread tests/e2e/run_e2e.py Outdated
@Shikugawa

Copy link
Copy Markdown
Member

This PR is very helpful and worth doing to implement other agent implementations using the same mechanism on regression tests, such as cpp2sky.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun

Copy link
Copy Markdown
Member Author

@Shikugawa @wu-sheng this PR is ready for review.

@wu-sheng
wu-sheng requested a review from Shikugawa January 22, 2022 12:06

@Shikugawa Shikugawa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Shikugawa
Shikugawa merged commit 39232e5 into apache:master Jan 22, 2022
@tisonkun
tisonkun deleted the e2e-liveness-probe branch January 22, 2022 16:59
@tisonkun

Copy link
Copy Markdown
Member Author

@Shikugawa thanks for your review! You may clean up the squash commit message the next time. I think most of them are meaningless. Or you can ask me to do the squash :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants