[Breaking Change] Enhance JDBC storage through merging table and managing day-based table rolling#10544
Merged
Conversation
wu-sheng
reviewed
Mar 16, 2023
wu-sheng
reviewed
Mar 16, 2023
Member
|
@kezhenxu94 As you are not implementing the ShardingSphere in this PR, please remove all relative codes and tests. If one day, we will add it back, we could pick from 9.4.0 branch. |
3 tasks
wu-sheng
added
core feature
wu-sheng
reviewed
Mar 17, 2023
Member
|
I think I am mostly done with high-priority things for now. |
wu-sheng
reviewed
Mar 17, 2023
wu-sheng
approved these changes
Mar 17, 2023
wu-sheng
left a comment
wu-sheng
left a comment
Member
There was a problem hiding this comment.
LGTM.
Commit logs
* [Breaking Change] Enhance JDBC storage through merging tables and managing day-based table rolling.
* [Breaking Change] Sharding-MySQL implementations and tests get removed due to we have the day-based rolling mechanism by default
Member
|
@wankai123 Please take a look. FYI @mrproliu I expect this would be merged soon, and your block will be gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.