Replace e2e cases to e2e-v2: Lua Nginx/SelfObservability.#7847
Merged
Conversation
wankai123
added
the
test
kezhenxu94
reviewed
Sep 30, 2021
…m:wankai123/skywalking into e2e-v2-so11y-lua
Member
|
Let's hold PR this a little bit, I've found some misuses of the verifier rules that affect the accuracy of the E2E and I am fixing, let's wait for the patch and there are some misuses in this PR that need adjustments. |
2 tasks
wu-sheng
approved these changes
Oct 11, 2021
kezhenxu94
approved these changes
Oct 11, 2021
| - key: {{ notEmpty .key }} | ||
| value: {{ ge .value 1 }} | ||
| {{- end }} | ||
| {{- end }} No newline at end of file |
Member
There was a problem hiding this comment.
Can you set the IDE and keep the new lines at the end of files? You can search on Google why we prefer a new line at the end of a file?
Member
There was a problem hiding this comment.
I think most of us are just randomly setting this, or use default setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.update some sample cases as well
update cli to
515a6a415f83a2e7ba114ca8c6fc79e2acd0ee4e