Skip to content

Support new records query protocol#9827

Merged
wu-sheng merged 5 commits into
apache:masterfrom
mrproliu:records
Oct 22, 2022
Merged

Support new records query protocol#9827
wu-sheng merged 5 commits into
apache:masterfrom
mrproliu:records

Conversation

@mrproliu

Copy link
Copy Markdown
Contributor
  1. Following Add new record query protocol. skywalking-query-protocol#100, adapt the new records query protocol. Rename the column name service_id to entity_id for support difference entity.
  2. Update the ProcessRegistry#generateVirtualProcess as public, It helps the network profiling not working in the Kubernetes environment.

@mrproliu mrproliu requested review from wu-sheng and yswdqz October 21, 2022 09:40
@mrproliu mrproliu added protocol agent->collector or UI->collector protocols related. query OAP query protocol related labels Oct 21, 2022
@mrproliu mrproliu added this to the 9.3.0 milestone Oct 21, 2022
@sonatype-lift

sonatype-lift Bot commented Oct 21, 2022

Copy link
Copy Markdown

⚠️ 6 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

wu-sheng
wu-sheng previously approved these changes Oct 21, 2022

@wu-sheng wu-sheng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng

Copy link
Copy Markdown
Member

Some tests fail, please recheck the changes.

@wu-sheng wu-sheng merged commit 2e6e3fa into apache:master Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

protocol agent->collector or UI->collector protocols related. query OAP query protocol related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants