[BUGFIX][SQL] Should match java.math.BigDecimal when wnrapping Hive output#1199
[BUGFIX][SQL] Should match java.math.BigDecimal when wnrapping Hive output#1199liancheng wants to merge 1 commit into
Conversation
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16073/ |
|
I think the |
|
Merged build triggered. |
|
The problem is fixed by PR #1201, rebased to the most recent master. |
|
Merged build started. |
|
Merged build triggered. |
|
Merged build started. |
|
Aren't we using Scala's BigDecimal? |
|
@rxin we are probably using scala's but this code is unwrapping values that come from hive. |
|
SGTM. We should probably switch to this: https://issues.apache.org/jira/browse/HIVE-6017 although it is a lower priority task (although for the purpose of API compatibility, maybe we want to make it higher priority0. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16095/ |
|
Weird, I can't reproduce the test failure locally, and the failed test case seems completely unrelated to the change... |
|
@marmbrus Would you mind to retest this? Thanks. |
|
OK, I reproduced it locally by running |
|
I'm going to merge this first since the test is most likely a different problem. |
…utput The `BigDecimal` branch in `unwrap` matches to `scala.math.BigDecimal` rather than `java.math.BigDecimal`. Author: Cheng Lian <lian.cs.zju@gmail.com> Closes #1199 from liancheng/javaBigDecimal and squashes the following commits: e9bb481 [Cheng Lian] Should match java.math.BigDecimal when wnrapping Hive output (cherry picked from commit 22036ae) Signed-off-by: Reynold Xin <rxin@apache.org>
…utput The `BigDecimal` branch in `unwrap` matches to `scala.math.BigDecimal` rather than `java.math.BigDecimal`. Author: Cheng Lian <lian.cs.zju@gmail.com> Closes apache#1199 from liancheng/javaBigDecimal and squashes the following commits: e9bb481 [Cheng Lian] Should match java.math.BigDecimal when wnrapping Hive output
…utput The `BigDecimal` branch in `unwrap` matches to `scala.math.BigDecimal` rather than `java.math.BigDecimal`. Author: Cheng Lian <lian.cs.zju@gmail.com> Closes apache#1199 from liancheng/javaBigDecimal and squashes the following commits: e9bb481 [Cheng Lian] Should match java.math.BigDecimal when wnrapping Hive output
* [CARMEL-6490] Lots of unfinished state sql in the query log * Fix ut
4 participants
The
BigDecimalbranch inunwrapmatches toscala.math.BigDecimalrather thanjava.math.BigDecimal.