[SPARK-2287] [SQL] Make ScalaReflection be able to handle Generic case classes. by ueshin · Pull Request #1226 · apache/spark

ueshin · 2014-06-26T06:40:36Z

No description provided.

AmplabJenkins · 2014-06-26T06:45:21Z

Merged build triggered.

AmplabJenkins · 2014-06-26T06:45:29Z

Merged build started.

ueshin · 2014-06-26T06:48:03Z

This will cause merge conflict with #1193, but I can fix it soon.

Conflicts: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala

AmplabJenkins · 2014-06-26T07:10:21Z

Merged build triggered.

AmplabJenkins · 2014-06-26T07:10:29Z

Merged build started.

ueshin · 2014-06-26T07:11:07Z

Fixed merge conflict with #1193.

AmplabJenkins · 2014-06-26T07:55:21Z

Merged build triggered.

AmplabJenkins · 2014-06-26T07:55:28Z

Merged build started.

AmplabJenkins · 2014-06-26T08:18:42Z

Merged build finished.

AmplabJenkins · 2014-06-26T08:18:42Z

Merged build finished.

AmplabJenkins · 2014-06-26T08:18:42Z

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16143/

AmplabJenkins · 2014-06-26T08:18:42Z

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16140/

AmplabJenkins · 2014-06-26T08:41:28Z

Merged build finished.

AmplabJenkins · 2014-06-26T08:41:28Z

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16147/

ueshin · 2014-06-26T09:45:28Z

Could you please retest this?
Previous tests seemed like Hive metastore was something wrong.
(Can I let Jenkins do retest?)

marmbrus · 2014-06-26T18:39:02Z

test this please

marmbrus · 2014-06-26T18:40:19Z

I think Jenkins only listens to committers, but you could always just push a new commit (or the same commit with something like git commit --amend; git push <remote> +<branchname>)

AmplabJenkins · 2014-06-26T18:40:25Z

Merged build triggered.

AmplabJenkins · 2014-06-26T18:40:32Z

Merged build started.

AmplabJenkins · 2014-06-26T19:44:08Z

Merged build finished.

AmplabJenkins · 2014-06-26T19:44:08Z

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16165/

ueshin · 2014-06-27T01:19:15Z

@marmbrus I see, I will do it next time, thanks.
But why failed...

marmbrus · 2014-06-27T01:44:08Z

Yeah, I don't know. Seems to work for me locally and you didn't touch anything hive related...

test this please

AmplabJenkins · 2014-06-27T08:30:25Z

Merged build triggered.

AmplabJenkins · 2014-06-27T08:30:32Z

Merged build started.

AmplabJenkins · 2014-06-27T10:08:53Z

Merged build finished.

AmplabJenkins · 2014-06-27T10:08:54Z

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16203/

ueshin · 2014-06-27T10:17:47Z

Passed Hive tests. Why? Just merged master.
And Python tests failed...

marmbrus · 2014-06-27T17:16:19Z

test this please.

AmplabJenkins · 2014-06-27T17:20:27Z

Merged build triggered.

AmplabJenkins · 2014-06-27T17:20:35Z

Merged build started.

AmplabJenkins · 2014-06-27T18:06:17Z

Merged build finished.

AmplabJenkins · 2014-06-27T18:06:17Z

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16210/

ueshin · 2014-06-28T03:11:58Z

Hi @marmbrus,

I found that there is a case at my local throwing the same exception with test-only like:

testOnly org.apache.spark.sql.hive.execution.PruningSuite

even if my patch is not applied.

And I added a line to PruningSuite

+  TestHive.loadTestTable("src")
  TestHive.reset()

then it worked.

Would it be a help for you?

ueshin · 2014-06-28T03:59:13Z

Ah, we must call SHOW TABLES before TestHive.reset() the same as here, right?

AmplabJenkins · 2014-06-28T04:05:28Z

Merged build triggered.

AmplabJenkins · 2014-06-28T04:05:34Z

Merged build started.

AmplabJenkins · 2014-06-28T05:45:31Z

Merged build finished. All automated tests passed.

AmplabJenkins · 2014-06-28T05:45:31Z

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16225/

…e classes. Author: Takuya UESHIN <ueshin@happy-camper.st> Closes #1226 from ueshin/issues/SPARK-2287 and squashes the following commits: 32ef7c3 [Takuya UESHIN] Add execution of `SHOW TABLES` before `TestHive.reset()`. 541dc8d [Takuya UESHIN] Merge branch 'master' into issues/SPARK-2287 fac5fae [Takuya UESHIN] Remove unnecessary method receiver. d306e60 [Takuya UESHIN] Merge branch 'master' into issues/SPARK-2287 7de5706 [Takuya UESHIN] Make ScalaReflection be able to handle Generic case classes. (cherry picked from commit bc7041a) Signed-off-by: Michael Armbrust <michael@databricks.com>

marmbrus · 2014-07-02T17:11:22Z

Thanks! I've merged this into master and the 1.0 branches.

…e classes. Author: Takuya UESHIN <ueshin@happy-camper.st> Closes apache#1226 from ueshin/issues/SPARK-2287 and squashes the following commits: 32ef7c3 [Takuya UESHIN] Add execution of `SHOW TABLES` before `TestHive.reset()`. 541dc8d [Takuya UESHIN] Merge branch 'master' into issues/SPARK-2287 fac5fae [Takuya UESHIN] Remove unnecessary method receiver. d306e60 [Takuya UESHIN] Merge branch 'master' into issues/SPARK-2287 7de5706 [Takuya UESHIN] Make ScalaReflection be able to handle Generic case classes.

### What changes were proposed in this pull request? This PR cherry-picks the code for SNAPSHOT and MIGRATE commands to Spark 3.2. ### Why are the changes needed? A catalog can now implement MigrateSupport and SnapshotSupport which are mapped to SQL that matches the ADT grammar used previously. ### Does this PR introduce _any_ user-facing change? Yes but the changes are isolated. ### How was this patch tested? This PR comes with tests. More tests in Iceberg.

Make ScalaReflection be able to handle Generic case classes.

7de5706

Merge branch 'master' into issues/SPARK-2287

d306e60

Conflicts: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala

Remove unnecessary method receiver.

fac5fae

Merge branch 'master' into issues/SPARK-2287

541dc8d

Add execution of SHOW TABLES before TestHive.reset().

32ef7c3

ueshin mentioned this pull request Jun 30, 2014

[SPARK-2328] [SQL] Add execution of SHOW TABLES before TestHive.reset(). #1268

Closed

asfgit closed this in bc7041a Jul 2, 2014

schlosna mentioned this pull request Feb 8, 2018

Bump codahale metrics palantir/spark#309

Closed

Uh oh!

Conversation

ueshin commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

ueshin commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

ueshin commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

ueshin commented Jun 26, 2014

Uh oh!

marmbrus commented Jun 26, 2014

Uh oh!

marmbrus commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

AmplabJenkins commented Jun 26, 2014

Uh oh!

ueshin commented Jun 27, 2014

Uh oh!

marmbrus commented Jun 27, 2014

Uh oh!

AmplabJenkins commented Jun 27, 2014

Uh oh!

AmplabJenkins commented Jun 27, 2014

Uh oh!

AmplabJenkins commented Jun 27, 2014

Uh oh!

AmplabJenkins commented Jun 27, 2014

Uh oh!

ueshin commented Jun 27, 2014

Uh oh!

marmbrus commented Jun 27, 2014

Uh oh!

AmplabJenkins commented Jun 27, 2014

Uh oh!

AmplabJenkins commented Jun 27, 2014

Uh oh!

AmplabJenkins commented Jun 27, 2014

Uh oh!

AmplabJenkins commented Jun 27, 2014

Uh oh!

ueshin commented Jun 28, 2014

Uh oh!

ueshin commented Jun 28, 2014

Uh oh!

AmplabJenkins commented Jun 28, 2014

Uh oh!

AmplabJenkins commented Jun 28, 2014

Uh oh!

AmplabJenkins commented Jun 28, 2014

Uh oh!