Skip to content

[SPARK-14344][SQL] Not creating meta files when summary-metadata property is false in parquet #12355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kasjain wants to merge 3 commits into from
Closed

[SPARK-14344][SQL] Not creating meta files when summary-metadata property is false in parquet #12355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4eb23fc
[SPARK-14344][SQL] Not creating meta files when summary-metadata prop…
kasjain Apr 13, 2016
085a562
[SPARK-14344][SQL] Not creating meta files when summary-metadata prop…
kasjain Apr 13, 2016
0421f4f
[SPARK-14344][SQL] Minor typo fix
kasjain Apr 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetRelation.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,21 @@ private[sql] object ParquetRelation {
// for the schema of a parquet data.
val schema = StructType.fromAttributes(attributes).asNullable
val newAttributes = schema.toAttributes
ParquetTypesConverter.writeMetaData(newAttributes, path, conf)
if (sqlContext.sparkContext.hadoopConfiguration
.getBoolean(ParquetOutputFormat.ENABLE_JOB_SUMMARY, true)) {
ParquetTypesConverter.writeMetaData(attributes, path, conf)
} else {
// Create only the directory without the metafile
val fs = path.getFileSystem(conf)
if (fs == null) {
throw new IllegalArgumentException(
s"ParquetRelation: Path $path is incorrectly formatted")
}
if (!fs.exists(path) || !fs.getFileStatus(path).isDir) {
fs.mkdirs(path)
}
}

new ParquetRelation(path.toString, Some(conf), sqlContext) {
override val output = newAttributes
}
Expand Down
4 changes: 4 additions & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,10 @@ private[parquet] object FileSystemHelper {
*/
def findMaxTaskId(pathStr: String, conf: Configuration): Int = {
val files = FileSystemHelper.listFiles(pathStr, conf)
// Return in case the "parquet.enable.summary-metadata" is false
if(files.size == 0) {
return 0
}
// filename pattern is part-r-<int>.parquet
val nameP = new scala.util.matching.Regex("""part-r-(\d{1,}).parquet""", "taskid")
val hiddenFileP = new scala.util.matching.Regex("_.*")
Expand Down