[SPARK-16142] [R] group naiveBayes method docs in a single Rd#13877
Closed
mengxr wants to merge 1 commit into
Closed
[SPARK-16142] [R] group naiveBayes method docs in a single Rd#13877mengxr wants to merge 1 commit into
mengxr wants to merge 1 commit into
Conversation
Contributor
Author
| # Makes predictions from a generalized linear model produced by glm() or spark.glm(), | ||
| # similarly to R's predict(). | ||
| #' | ||
|
|
Contributor
Author
There was a problem hiding this comment.
this fixes small style issues from #13820
|
Test build #61128 has finished for PR 13877 at commit
|
| #' @return \code{spark.naiveBayes} returns a fitted naive Bayes model | ||
| #' @rdname spark.naiveBayes | ||
| #' @name spark.naiveBayes | ||
| #' @seealso e1071: \url{https://cran.r-project.org/web/packages/e1071/} |
Contributor
There was a problem hiding this comment.
do we want to hide the url?
Contributor
Author
There was a problem hiding this comment.
roxygen2 only supports raw url links.
Contributor
There was a problem hiding this comment.
We could use the \link tag as discussed in http://stackoverflow.com/questions/25489042/linking-to-other-packages-in-documentation-in-roxygen2-in-r
Contributor
|
The new document in the screenshot looks pretty good to me. |
asfgit
pushed a commit
that referenced
this pull request
Jun 24, 2016
## What changes were proposed in this pull request? This PR groups `spark.naiveBayes`, `summary(NB)`, `predict(NB)`, and `write.ml(NB)` into a single Rd. ## How was this patch tested? Manually checked generated HTML doc. See attached screenshots.   Author: Xiangrui Meng <meng@databricks.com> Closes #13877 from mengxr/SPARK-16142. (cherry picked from commit 4a40d43) Signed-off-by: Xiangrui Meng <meng@databricks.com>
Contributor
Author
|
Merged into master and branch-2.0. Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR groups
spark.naiveBayes,summary(NB),predict(NB), andwrite.ml(NB)into a single Rd.How was this patch tested?
Manually checked generated HTML doc. See attached screenshots.